Remove fewer Storage calls in CopyProp and GVN by ohadravid · Pull Request #142531 · rust-lang/rust (original) (raw)
Finished benchmarking commit (ef7d206): comparison URL.
Overall result: ❌ regressions - please read the text below
Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.
Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.
@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | 0.3% | [0.2%, 0.4%] | 8 |
| Regressions ❌ (secondary) | 0.3% | [0.2%, 0.4%] | 7 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | 0.3% | [0.2%, 0.4%] | 8 |
Max RSS (memory usage)
Results (primary 0.7%, secondary 3.4%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | 3.5% | [1.8%, 5.0%] | 5 |
| Regressions ❌ (secondary) | 3.4% | [3.4%, 3.4%] | 1 |
| Improvements ✅ (primary) | -3.9% | [-6.5%, -2.0%] | 3 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | 0.7% | [-6.5%, 5.0%] | 8 |
Cycles
Results (primary -0.6%, secondary -0.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | 3.8% | [3.8%, 3.8%] | 1 |
| Improvements ✅ (primary) | -0.6% | [-0.6%, -0.6%] | 1 |
| Improvements ✅ (secondary) | -4.1% | [-4.1%, -4.1%] | 1 |
| All ❌✅ (primary) | -0.6% | [-0.6%, -0.6%] | 1 |
Binary size
Results (primary 0.0%, secondary 0.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | 0.2% | [0.0%, 0.8%] | 10 |
| Regressions ❌ (secondary) | 0.1% | [0.0%, 0.1%] | 5 |
| Improvements ✅ (primary) | -0.2% | [-0.8%, -0.0%] | 8 |
| Improvements ✅ (secondary) | -0.2% | [-0.2%, -0.2%] | 1 |
| All ❌✅ (primary) | 0.0% | [-0.8%, 0.8%] | 18 |
Bootstrap: 757.399s -> 756.065s (-0.18%)
Artifact size: 372.20 MiB -> 372.12 MiB (-0.02%)