Use ExtractIf in fulfillment loop by compiler-errors · Pull Request #144699 · rust-lang/rust (original) (raw)
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Status: This is awaiting some action (such as code changes or more information) from the author.
Relevant to the compiler team, which will review and decide on the PR/issue.
The Rustc Trait System Refactor Initiative (-Znext-solver)
labels
This comment has been minimized.
⌛ Trying commit eb04ad7 with merge e2ca90c…
To cancel the try build, run the command @bors try cancel.
rust-bors bot added a commit that referenced this pull request
Use ExtractIf in fulfillment loop
☀️ Try build successful (CI)
Build commit: e2ca90c (e2ca90cb247ff049a778754d8064e41014ba4ebb, parent: e5e79f8bd428d0b8d26e8240d718b134ef297459)
This comment has been minimized.
Finished benchmarking commit (e2ca90c): comparison URL.
Overall result: ❌✅ regressions and improvements - please read the text below
Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.
Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.
@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | 0.9% | [0.9%, 1.0%] | 6 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | -1.3% | [-2.4%, -0.4%] | 14 |
| All ❌✅ (primary) | - | - | 0 |
Max RSS (memory usage)
Results (secondary -2.8%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | - | - | 0 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | -2.8% | [-2.8%, -2.8%] | 1 |
| All ❌✅ (primary) | - | - | 0 |
Cycles
Results (secondary 4.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | 4.0% | [2.4%, 7.7%] | 5 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | - | - | 0 |
Binary size
Results (secondary -0.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | - | - | 0 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | -0.0% | [-0.0%, -0.0%] | 1 |
| All ❌✅ (primary) | - | - | 0 |
Bootstrap: 469.342s -> 468.218s (-0.24%)
Artifact size: 376.86 MiB -> 377.02 MiB (0.04%)
match-stress being noisy again ofc sad trombone
This comment has been minimized.
⌛ Trying commit dfc9304 with merge b8a2577…
To cancel the try build, run the command @bors try cancel.
rust-bors bot added a commit that referenced this pull request
Use ExtractIf in fulfillment loop
☀️ Try build successful (CI)
Build commit: b8a2577 (b8a25775bd061d360019dc44978c4f9e7c761aab, parent: 3fb1b53a9dbfcdf37a4b67d35cde373316829930)
This comment has been minimized.
Finished benchmarking commit (b8a2577): comparison URL.
Overall result: ❌✅ regressions and improvements - please read the text below
Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.
Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.
@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | 0.2% | [0.0%, 0.7%] | 8 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | -1.1% | [-3.0%, -0.0%] | 14 |
| All ❌✅ (primary) | - | - | 0 |
Max RSS (memory usage)
Results (secondary -1.2%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | 2.7% | [1.5%, 3.6%] | 5 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | -4.1% | [-4.5%, -2.6%] | 7 |
| All ❌✅ (primary) | - | - | 0 |
Cycles
Results (secondary -2.5%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | 4.5% | [3.3%, 5.8%] | 2 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | -4.5% | [-9.7%, -1.8%] | 7 |
| All ❌✅ (primary) | - | - | 0 |
Binary size
Results (secondary 0.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | 0.0% | [0.0%, 0.0%] | 1 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | - | - | 0 |
Bootstrap: 467.851s -> 468.536s (0.15%)
Artifact size: 376.84 MiB -> 377.63 MiB (0.21%)