Automatically switch to lto-fat when flag RUSTFLAGS="- Zautodiff=Enable" is set by Hayden602 · Pull Request #146229 · rust-lang/rust (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this to explain why we do it? Something along the lines of

// Autodiff currently requires fat-lto to have access to the llvm-ir of all (indirectly) used functions and types. fat-lto is the easiest solution to this requirement, but quite expensive. FIXME(autodiff): Make autodiff also work with embed-bc instead of fat-lto.

When you change it, please update your last commit and force push, don't make a second commit just for doc changes.

Otherwise lgtm. Sorry for taking so long, I was traveling and wanted to test it locally.