cg_llvm: Move target machine command-line quoting from C++ to Rust by Zalathar · Pull Request #146700 · rust-lang/rust (original) (raw)

Finished benchmarking commit (44b341a): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌ (primary) 0.2% [0.2%, 0.2%] 2
Regressions ❌ (secondary) 0.2% [0.1%, 0.3%] 16
Improvements ✅ (primary) -0.4% [-0.5%, -0.2%] 4
Improvements ✅ (secondary) -3.1% [-23.4%, -0.2%] 15
All ❌✅ (primary) -0.2% [-0.5%, 0.2%] 6

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary -5.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌ (primary) - - 0
Regressions ❌ (secondary) 2.1% [2.1%, 2.1%] 1
Improvements ✅ (primary) - - 0
Improvements ✅ (secondary) -9.0% [-9.4%, -8.6%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 471.663s -> 472.562s (0.19%)
Artifact size: 387.94 MiB -> 387.87 MiB (-0.02%)