chore: fix setup script errors by zkpepe · Pull Request #146729 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

made the setup script more reliable:

MIRRORS_BASE now errors if missing.
RUST_CONFIGURE_ARGS defaults to empty.
mkdir -p ninja avoids “already exists” errors.
curl -fLo follows redirects and fails on HTTP errors.

simple, clear, and it just works.

r? @marcoieni

rustbot has assigned @marcoieni.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added A-CI

Area: Our Github Actions CI

A-testsuite

Area: The testsuite used to check the correctness of rustc

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-infra

Relevant to the infrastructure team, which will review and decide on the PR/issue.

labels

Sep 18, 2025

Comment on lines +9 to +11

# Check and set default values for variables
: "${MIRRORS_BASE:?MIRRORS_BASE is not set}"
: "${RUST_CONFIGURE_ARGS:=}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# Check and set default values for variables
: "${MIRRORS_BASE:?MIRRORS_BASE is not set}"
: "${RUST_CONFIGURE_ARGS:=}"
# Fail is variable is not set
: "${MIRRORS_BASE:?MIRRORS_BASE is not set}"
# Set the variable to an empty string if it's undefined
: "${RUST_CONFIGURE_ARGS:=}"

Thanks, this looks good, I just left a small improvements for the comment.
After you make the change, please squash your commits and I will approve 🙏

Labels