Avoid LocalCopy instantiation for #[inline] on -Copt-level=0 by Noratrieb · Pull Request #147351 · rust-lang/rust (original) (raw)

Finished benchmarking commit (85bd5e8): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌ (primary) 23.3% [0.1%, 897.4%] 48
Regressions ❌ (secondary) 2.7% [0.1%, 32.6%] 43
Improvements ✅ (primary) -1.4% [-4.6%, -0.2%] 20
Improvements ✅ (secondary) -0.1% [-0.1%, -0.1%] 2
All ❌✅ (primary) 16.0% [-4.6%, 897.4%] 68

Max RSS (memory usage)

Results (primary 2.0%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌ (primary) 4.4% [0.8%, 15.6%] 24
Regressions ❌ (secondary) 5.8% [1.4%, 12.4%] 11
Improvements ✅ (primary) -2.7% [-6.8%, -0.8%] 12
Improvements ✅ (secondary) -4.4% [-6.9%, -1.8%] 14
All ❌✅ (primary) 2.0% [-6.8%, 15.6%] 36

Cycles

Results (primary 52.9%, secondary 5.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌ (primary) 61.9% [2.3%, 923.3%] 19
Regressions ❌ (secondary) 8.2% [2.0%, 26.5%] 14
Improvements ✅ (primary) -4.0% [-4.8%, -3.3%] 3
Improvements ✅ (secondary) -3.7% [-6.6%, -1.1%] 5
All ❌✅ (primary) 52.9% [-4.8%, 923.3%] 22

Binary size

Results (primary 7.6%, secondary 14.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌ (primary) 12.6% [1.2%, 67.5%] 55
Regressions ❌ (secondary) 15.3% [1.3%, 78.2%] 27
Improvements ✅ (primary) -1.9% [-9.1%, -0.2%] 29
Improvements ✅ (secondary) -0.2% [-0.4%, -0.0%] 2
All ❌✅ (primary) 7.6% [-9.1%, 67.5%] 84

Bootstrap: 471.44s -> 471.725s (0.06%)
Artifact size: 388.29 MiB -> 387.96 MiB (-0.09%)