Make inliner cycle detection a fallible process by saethlin · Pull Request #147361 · rust-lang/rust (original) (raw)
Finished benchmarking commit (415a8b5): comparison URL.
Overall result: ❌✅ regressions and improvements - please read the text below
Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.
Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.
@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | 0.3% | [0.3%, 0.3%] | 1 |
| Regressions ❌ (secondary) | 0.5% | [0.1%, 1.4%] | 17 |
| Improvements ✅ (primary) | -1.2% | [-2.3%, -0.7%] | 4 |
| Improvements ✅ (secondary) | -0.6% | [-5.0%, -0.1%] | 30 |
| All ❌✅ (primary) | -0.9% | [-2.3%, 0.3%] | 5 |
Max RSS (memory usage)
Results (primary -4.2%, secondary -3.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | 2.7% | [0.9%, 4.8%] | 3 |
| Improvements ✅ (primary) | -4.2% | [-4.2%, -4.2%] | 1 |
| Improvements ✅ (secondary) | -4.3% | [-6.6%, -1.7%] | 13 |
| All ❌✅ (primary) | -4.2% | [-4.2%, -4.2%] | 1 |
Cycles
Results (secondary 0.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | 3.3% | [2.1%, 4.3%] | 4 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | -3.1% | [-4.8%, -1.1%] | 4 |
| All ❌✅ (primary) | - | - | 0 |
Binary size
Results (primary -0.0%, secondary 0.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | 0.3% | [0.0%, 1.1%] | 4 |
| Regressions ❌ (secondary) | 0.5% | [0.0%, 1.1%] | 2 |
| Improvements ✅ (primary) | -0.1% | [-0.3%, -0.0%] | 9 |
| Improvements ✅ (secondary) | -0.1% | [-0.6%, -0.0%] | 14 |
| All ❌✅ (primary) | -0.0% | [-0.3%, 1.1%] | 13 |
Bootstrap: 470.078s -> 463.689s (-1.36%)
Artifact size: 388.29 MiB -> 387.90 MiB (-0.10%)