Fix issue with callsite inline attribute not being applied sometimes. by JamieCunliffe · Pull Request #147404 · rust-lang/rust (original) (raw)
Finished benchmarking commit (1eb0657): comparison URL.
Overall result: ❌✅ regressions and improvements - please read the text below
Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.
Next Steps:
- If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add@rustbot label: +perf-regression-triagedto it, to mark the regression as triaged. - If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression. - If you do not understand the regression or you think that it is just noise,
you can ask the@rust-lang/wg-compiler-performanceworking group for help (members of this group
were already notified of this PR).
@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | 0.4% | [0.3%, 0.4%] | 2 |
| Regressions ❌ (secondary) | 0.2% | [0.1%, 0.3%] | 5 |
| Improvements ✅ (primary) | -0.1% | [-0.1%, -0.1%] | 2 |
| Improvements ✅ (secondary) | -0.2% | [-0.4%, -0.1%] | 22 |
| All ❌✅ (primary) | 0.1% | [-0.1%, 0.4%] | 4 |
Max RSS (memory usage)
Results (secondary -4.6%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | - | - | 0 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | -4.6% | [-4.6%, -4.6%] | 1 |
| All ❌✅ (primary) | - | - | 0 |
Cycles
Results (secondary -0.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | 4.4% | [4.4%, 4.4%] | 1 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | -2.4% | [-2.6%, -2.2%] | 2 |
| All ❌✅ (primary) | - | - | 0 |
Binary size
Results (secondary -0.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | - | - | 0 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | -0.0% | [-0.0%, -0.0%] | 1 |
| All ❌✅ (primary) | - | - | 0 |
Bootstrap: 472.717s -> 472.886s (0.04%)
Artifact size: 386.88 MiB -> 386.93 MiB (0.01%)