Fix check_expr_if to point to a more accurate location of the compilation error in some cases by sgasho · Pull Request #147484 · rust-lang/rust (original) (raw)
Finished benchmarking commit (9877dbd): comparison URL.
Overall result: ✅ improvements - no action needed
Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.
@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | - | - | 0 |
| Improvements ✅ (primary) | -0.3% | [-0.3%, -0.3%] | 1 |
| Improvements ✅ (secondary) | -0.1% | [-0.1%, -0.1%] | 2 |
| All ❌✅ (primary) | -0.3% | [-0.3%, -0.3%] | 1 |
Max RSS (memory usage)
Results (primary 0.0%, secondary -2.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | 5.9% | [5.9%, 5.9%] | 1 |
| Regressions ❌ (secondary) | - | - | 0 |
| Improvements ✅ (primary) | -3.0% | [-3.6%, -2.3%] | 2 |
| Improvements ✅ (secondary) | -2.1% | [-2.1%, -2.1%] | 1 |
| All ❌✅ (primary) | 0.0% | [-3.6%, 5.9%] | 3 |
Cycles
Results (secondary 1.7%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | 6.5% | [6.5%, 6.5%] | 1 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | -3.1% | [-3.1%, -3.1%] | 1 |
| All ❌✅ (primary) | - | - | 0 |
Binary size
Results (primary 0.0%, secondary 0.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | 0.2% | [0.1%, 0.3%] | 4 |
| Regressions ❌ (secondary) | 0.1% | [0.1%, 0.1%] | 1 |
| Improvements ✅ (primary) | -0.1% | [-0.1%, -0.1%] | 3 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | 0.0% | [-0.1%, 0.3%] | 7 |
Bootstrap: 474.307s -> 475.954s (0.35%)
Artifact size: 390.07 MiB -> 390.09 MiB (0.00%)