Show packed field alignment in mir_transform_unaligned_packed_ref by 21aslade · Pull Request #147743 · rust-lang/rust (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and welcome to working on the compiler! Have a few comments, see below. Remember to squash once you're done.

Also, I see that you originally implemented the full message as discussed by the referenced issue, but then decided to do something simpler - could you edit your top-level comment to discuss why this wasn't done in the end? (see the review policy for why to put stuff in the PR message).

View changes since this review