Vec::push in consts MVP by fee1-dead · Pull Request #147893 · rust-lang/rust (original) (raw)

Finished benchmarking commit (b3f7ade): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌ (primary) 0.3% [0.3%, 0.3%] 1
Regressions ❌ (secondary) 0.2% [0.1%, 0.2%] 3
Improvements ✅ (primary) -0.6% [-0.6%, -0.6%] 1
Improvements ✅ (secondary) - - 0
All ❌✅ (primary) -0.2% [-0.6%, 0.3%] 2

Max RSS (memory usage)

Results (primary 0.4%, secondary -0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌ (primary) 2.7% [1.3%, 4.5%] 5
Regressions ❌ (secondary) 3.7% [3.7%, 3.7%] 1
Improvements ✅ (primary) -2.0% [-3.3%, -0.4%] 5
Improvements ✅ (secondary) -2.3% [-3.1%, -1.6%] 2
All ❌✅ (primary) 0.4% [-3.3%, 4.5%] 10

Cycles

Results (primary 3.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌ (primary) 3.3% [3.3%, 3.3%] 1
Regressions ❌ (secondary) - - 0
Improvements ✅ (primary) - - 0
Improvements ✅ (secondary) - - 0
All ❌✅ (primary) 3.3% [3.3%, 3.3%] 1

Binary size

Results (primary 0.3%, secondary 0.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌ (primary) 0.4% [0.0%, 1.5%] 33
Regressions ❌ (secondary) 0.6% [0.0%, 1.0%] 66
Improvements ✅ (primary) -0.2% [-0.5%, -0.0%] 5
Improvements ✅ (secondary) -0.1% [-0.1%, -0.1%] 1
All ❌✅ (primary) 0.3% [-0.5%, 1.5%] 38

Bootstrap: 473.751s -> 473.82s (0.01%)
Artifact size: 390.43 MiB -> 390.55 MiB (0.03%)