resolve: Partially convert ambiguous_glob_imports lint into a hard error by petrochenkov · Pull Request #149195 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation40 Commits1 Checks11 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
I'm tired of this logic interfering with any attempts to fix or refactor glob imports.
The lint was implemented 2.3 years ago, and made deny-by-default and report-in-dependencies 4 months ago.
The removal is a bit over-eager because of one piece that wasn't implemented correctly (#113099 (comment)), but I want to look at the crater results.
Part of #114095.
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
r? @nnethercote
rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
This comment has been minimized.
rust-bors bot added a commit that referenced this pull request
resolve: Convert ambiguous_glob_imports lint into a hard error
☀️ Try build successful (CI)
Build commit: 446cb60 (446cb600aa4837dd6c513f14fa0d25a909b177d7, parent: e22dab387f6b4f6a87dfc54ac2f6013dddb41e68)
This comment was marked as resolved.
🚧 Experiment pr-149195 is now running
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more
🎉 Experiment pr-149195 is completed!
📊 2676 regressed and 6 fixed (741888 total)
📊 2000 spurious results on the retry-regessed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.
⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more
Footnotes
- re-run the experiment with
crates=https://crater-reports.s3.amazonaws.com/pr-149195/retry-regressed-list.txt↩
@petrochenkov: seems like a lot of regressions :( Should I review this?
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Reminder, once the PR becomes ready for a review, use @rustbot ready.
The largest part of the regressions are from openssl-0.10.*, it's a known issue that is addressed by #147984.
So this is blocked by #147984 now.
@rustbot blocked
Status: Blocked on something else such as an RFC or other implementation work.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Correct me if I'm wrong on this one
@rustbot author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-blocked
Status: Blocked on something else such as an RFC or other implementation work.
labels
This comment has been minimized.
This comment has been minimized.
rust-bors bot added a commit that referenced this pull request
resolve: Partially convert ambiguous_glob_imports lint into a hard error
This comment has been minimized.
☀️ Try build successful (CI)
Build commit: 9cbe924 (9cbe924c1a7ad92a8d63366fe967735898f13b4d, parent: 3391c0133661be933c3ef24edf1867d71b9f206b)
@craterbot p=11
All the small runs will complete in a few hours and won't need to wait for a few days until the long beta runs complete.
📝 Configuration of the pr-149195-2 experiment changed.
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more
🚧 Experiment pr-149195-2 is now running
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more
🎉 Experiment pr-149195-2 is completed!
📊 466 regressed and 0 fixed (758 total)
📊 36 spurious results on the retry-regessed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.
⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more
Footnotes
- re-run the experiment with
crates=https://crater-reports.s3.amazonaws.com/pr-149195-2/retry-regressed-list.txt↩
Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
label
This comment has been minimized.
This comment has been minimized.
These commits modify tests/rustdoc-json.
rustdoc-json is a public (but unstable) interface.
Please ensure that if you've changed the output:
- It's intentional.
- The
FORMAT_VERSIONinsrc/librustdoc-json-typesis bumped if necessary.
cc @aDotInTheVoid, @obi1kenobi
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
Labels
Area: Name/path resolution done by `rustc_resolve` specifically
Area: Rustdoc JSON backend
Status: This is awaiting some action (such as code changes or more information) from the author.
Relevant to the compiler team, which will review and decide on the PR/issue.
Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.