Do not trust bootstrap about git hash availability by jieyouxu · Pull Request #149377 · rust-lang/rust (original) (raw)

Copy link

Member

@jieyouxu jieyouxu commented

Nov 27, 2025

edited

Loading

Since the bootstrap implementation can contain bugs. See #132845 and #132875.

Instead, we use RUSTC_TEST_GIT_HASH env var that is directly set by CI, or by the user locally, to control when the tests/run-make/version-verbose-commit-hash gets run. Note that locally, setting RUSTC_TEST_GIT_HASH=1 only forces the test to run; the test will only pass if git hash is available, i.e. explicitly opt-in, or using a non-dev channel.

Fixes #132875.

r? ghost

try-job: aarch64-apple
try-job: test-various