Port doc attributes to new attribute API by GuillaumeGomez · Pull Request #149645 · rust-lang/rust (original) (raw)

Finished benchmarking commit (5b150d2): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌ (primary) 0.2% [0.2%, 0.2%] 1
Regressions ❌ (secondary) 1.4% [0.1%, 3.1%] 18
Improvements ✅ (primary) -0.6% [-1.3%, -0.2%] 36
Improvements ✅ (secondary) -0.6% [-1.2%, -0.1%] 32
All ❌✅ (primary) -0.6% [-1.3%, 0.2%] 37

Max RSS (memory usage)

Results (primary -0.9%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌ (primary) 1.3% [1.1%, 1.4%] 2
Regressions ❌ (secondary) 1.8% [1.0%, 3.2%] 3
Improvements ✅ (primary) -1.4% [-3.2%, -0.5%] 9
Improvements ✅ (secondary) -1.1% [-2.3%, -0.7%] 4
All ❌✅ (primary) -0.9% [-3.2%, 1.4%] 11

Cycles

Results (primary -2.4%, secondary 2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌ (primary) - - 0
Regressions ❌ (secondary) 3.0% [1.7%, 6.8%] 9
Improvements ✅ (primary) -2.4% [-2.4%, -2.4%] 1
Improvements ✅ (secondary) -2.6% [-2.6%, -2.6%] 1
All ❌✅ (primary) -2.4% [-2.4%, -2.4%] 1

Binary size

Results (primary -0.4%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌ (primary) 0.1% [0.0%, 0.3%] 30
Regressions ❌ (secondary) 0.0% [0.0%, 0.0%] 9
Improvements ✅ (primary) -0.8% [-3.1%, -0.0%] 34
Improvements ✅ (secondary) -0.2% [-0.3%, -0.0%] 16
All ❌✅ (primary) -0.4% [-3.1%, 0.3%] 64

Bootstrap: 472.896s -> 473.727s (0.18%)
Artifact size: 389.04 MiB -> 389.29 MiB (0.06%)