[beta] Backport rust-analyzer proc macro server "disable postcard use temporarily" by lnicola · Pull Request #149799 · rust-lang/rust (original) (raw)
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.
cc @rust-lang/rust-analyzer
rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
⚠️ Warning ⚠️
- Pull requests are usually filed against the main branch for this repo, but this one is against beta. Please double check that you specified the right target!
@bors rollup=always
(EDIT: not actually sure whether beta backports can be rolled up)
EDIT: not actually sure whether beta backports can be rolled up
They must not be rolled up (for directly beta-branch targetting PRs, not the main-targetting ones that are intended to be cherry-picked after they merge into main), because PRs in a rollup target main, but this beta backport is targetting the beta branch directly.
@bors rollup=never
@lnicola also wait, is this intended for 1.92.0
⚠️ Warning ⚠️
- Pull requests are usually filed against the main branch for this repo, but this one is against beta. Please double check that you specified the right target!
(Also random tip: IIRC this message will be suppressed if you write "[beta]" in the backport PR title :D)
| [[assign.warn_non_default_branch.exceptions]] |
|---|
| title = "[beta" |
| branch = "beta" |
| [[assign.warn_non_default_branch.exceptions]] |
| title = "[stable" |
| branch = "stable" |
Backport rust-analyzer proc macro server "disable postcard use temporarily" [beta] Backport rust-analyzer proc macro server "disable postcard use temporarily"
So how does this work, do we have to wait until 1.92 comes out, or can we merge it now?
So how does this work, do we have to wait until 1.92 comes out, or can we merge it now?
My understanding this that this should be okay to merge since we prepped the beta branch already as part of the release process (#149760), but worth double-checking with release team #t-release1
EDIT: #t-release > 1.93-targetting r-a beta backport
Footnotes
- Since I have to wrap my head around which is which every time 😆 ↩
We can merge this now, right?
@bors r+
📌 Commit 51da96d has been approved by lnicola
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels