[PERF ONLY] rustdoc stringdex update by notriddle · Pull Request #149887 · rust-lang/rust (original) (raw)
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Area: The tidy tool
Status: This is awaiting some action (such as code changes or more information) from the author.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
labels
This comment has been minimized.
This comment has been minimized.
rust-bors bot added a commit that referenced this pull request
[PERF ONLY] rustdoc stringdex update
This comment has been minimized.
☀️ Try build successful (CI)
Build commit: 032b906 (032b906243bfa5eb6e1ab0349b24b05a55caf840, parent: f5209000832c9d3bc29c91f4daef4ca9f28dc797)
This comment has been minimized.
Finished benchmarking commit (032b906): comparison URL.
Overall result: ✅ improvements - no action needed
Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.
@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | - | - | 0 |
| Improvements ✅ (primary) | -0.2% | [-0.2%, -0.2%] | 1 |
| Improvements ✅ (secondary) | -0.3% | [-0.5%, -0.2%] | 3 |
| All ❌✅ (primary) | -0.2% | [-0.2%, -0.2%] | 1 |
Max RSS (memory usage)
Results (primary -4.3%, secondary -0.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | 2.8% | [2.8%, 2.8%] | 1 |
| Improvements ✅ (primary) | -4.3% | [-4.3%, -4.3%] | 1 |
| Improvements ✅ (secondary) | -3.0% | [-3.0%, -3.0%] | 1 |
| All ❌✅ (primary) | -4.3% | [-4.3%, -4.3%] | 1 |
Cycles
Results (primary -2.9%, secondary 4.6%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | 4.6% | [4.6%, 4.6%] | 1 |
| Improvements ✅ (primary) | -2.9% | [-2.9%, -2.9%] | 1 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | -2.9% | [-2.9%, -2.9%] | 1 |
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 472.896s -> 474.902s (0.42%)
Artifact size: 389.04 MiB -> 389.06 MiB (0.01%)
This comment has been minimized.
rust-bors bot added a commit that referenced this pull request
[PERF ONLY] rustdoc stringdex update
This comment has been minimized.
☀️ Try build successful (CI)
Build commit: 628c1c5 (628c1c5dc337f167612cd6ef886b72a76d41a264, parent: 3391c0133661be933c3ef24edf1867d71b9f206b)
This comment has been minimized.
Finished benchmarking commit (628c1c5): comparison URL.
Overall result: ✅ improvements - no action needed
Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.
@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | - | - | 0 |
| Improvements ✅ (primary) | -0.3% | [-0.3%, -0.3%] | 1 |
| Improvements ✅ (secondary) | -0.5% | [-0.5%, -0.5%] | 1 |
| All ❌✅ (primary) | -0.3% | [-0.3%, -0.3%] | 1 |
Max RSS (memory usage)
Results (secondary -2.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | - | - | 0 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | -2.1% | [-3.1%, -1.1%] | 2 |
| All ❌✅ (primary) | - | - | 0 |
Cycles
Results (secondary -1.8%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | 2.7% | [2.7%, 2.7%] | 1 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | -2.9% | [-4.6%, -1.9%] | 4 |
| All ❌✅ (primary) | - | - | 0 |
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 473.663s -> 474.105s (0.09%)
Artifact size: 389.32 MiB -> 389.30 MiB (-0.00%)
I like the CPU and doc_files_count results.
I’m less fond of doc_bytes, but that’s tiny, and it seems like an unavoidable side effect of bundling.
The doc_bytes regression is tiny, IMHO. I think the results look great!
That definitely seems positive, well done. :)
Labels
Area: The tidy tool
Status: This is awaiting some action (such as code changes or more information) from the author.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.