Refactor macro resolution errors + add derive macro suggestions by keeperofdakeys · Pull Request #39752 · rust-lang/rust (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just remove this comment -- since expansion and import resolution are interleaved, there's no way to perform after_expand before import resolution, so we don't need to warn people about this.

Also, we can move after_expand(&krate)? outside of time(time_passes, "name resolution", ...) now, I think it would be best to put it just before expansion debugging diagnostics ("Post-expansion node count", etc.).