Stabilized vec_splice and modified splice tracking issue by budziq · Pull Request #44640 · rust-lang/rust (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it isn't clear from the tracking issue -- but when the libs team discussed stabilizing Vec::splice and String::splice, we decided to stabilize Vec::splice but try a new signature for String::splice and keep it unstable. I left a comment on the tracking issue just now to clarify this.

Please keep the unstable attribute on String::splice for now and change its tracking issue number to point to #44643. Since we are stabilizing one but not the other, they will need to have different feature names. We can minimize breakage by changing Vec::splice to be under the now-stable feature vec_splice and keeping String::splice under feature(splice).

#[stable(feature = "vec_splice", since = "1.22.0")]

#[unstable(feature = "splice", reason = "...", issue = "44643")]

Thanks!