Add approximate suggestions for rustfix by Manishearth · Pull Request #47540 · rust-lang/rust (original) (raw)

Code looks fine (thanks for the changes!), I do still have some qualms about the naming, however: there is one concept here, but two names: machine_applicable and approximate and unfortunately, they have opposite truth values. I think it would be best to choose one or the other and only use that term. I would prefer machine_applicable, but that would mean that the default for the suggestion functions would be false and you would use machine_applicable_suggestion, etc. (I actually think that is the right default, but I'm willing to believe it is not).

Anyway, I'm happy either way, but I would like just one term.