Rollup of 5 pull requests by Centril · Pull Request #64321 · rust-lang/rust (original) (raw)

@tmandry Rolling up 3 PRs that affect the toolstate will almost certainly fail the rollup. I should probably not have rolled up RLS/rustfmt either but they are usually less risky than Clippy.

Okay, that makes sense.

From the perspective of a project using nightly builds that wants to update to a new version, it typically doesn't make much difference if 1 tool or 4 tools are broken. In theory, any given tool might be used by some person on the team, so it's binary: the only "safe" update is when all tools are green.

Therefore, I have a proposal: if there are changes queued up that, together, would get toolstate all-green again, can they be bundled as a single rollup and given priority? That way,

1. We won't waste CI resources on prioritizing changes that fix individual tools (which are likely to break again soon) when other tools remain broken.
2. When the "stars align" and we have fixes for all tools ready to go, we can prioritize that so master is all-green more of the time (and hopefully more nightlies will be, too.)

I should definitely post this somewhere else, just not sure where :)