Add Item::is_fake for rustdoc by jyn514 · Pull Request #73098 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

I wasn't aware items could be fake, so I think having a function
mentioning it could be helpful. Also, I'd need to make this change for
cross-crate intra-doc links anyway, so I figured it's better to make the
refactor separate.

I wasn't aware items could be fake, so I think having a function mentioning it could be helpful. Also, I'd need to make this change for cross-crate intra-doc links anyway, so I figured it's better to make the refactor separate.

r? @GuillaumeGomez

(rust_highfive has picked a reviewer for you, use r? to override)

Thanks! It indeed makes code a bit easier. :)

@bors: r+

📌 Commit 1f11331 has been approved by GuillaumeGomez

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jun 7, 2020

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request

Jun 7, 2020

…Gomez

Add Item::is_fake for rustdoc

I wasn't aware items could be fake, so I think having a function mentioning it could be helpful. Also, I'd need to make this change for cross-crate intra-doc links anyway, so I figured it's better to make the refactor separate.

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request

Jun 9, 2020

…Gomez

Add Item::is_fake for rustdoc

I wasn't aware items could be fake, so I think having a function mentioning it could be helpful. Also, I'd need to make this change for cross-crate intra-doc links anyway, so I figured it's better to make the refactor separate.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 10, 2020

jyn514 deleted the rustdoc-is-fake branch

June 10, 2020 04:06

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.