[RFC 2011] Minimal initial implementation by c410-f3r · Pull Request #97665 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation39 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Tracking issue: #44838
Third step of #96496
Implementation has ~290 LOC with the bare minimum to be in a functional state. Currently only searches for binary operations to mimic what assert_eq! and assert_ne! already do.
r? @oli-obk
Relevant to the compiler team, which will review and decide on the PR/issue.
label
This comment has been minimized.
This comment has been minimized.
Can the PR description be updated with links to the RFC and/or tracking issue? (Ideally the title should also be representative, but that's not as big of a deal)
[RFC 2011] Initial implementation [RFC 2011] Minimal initial implementation
Can the PR description be updated with links to the RFC and/or tracking issue? (Ideally the title should also be representative, but that's not as big of a deal)
Done
I won't get to this before 2022-06-13 (in 10 days).
I won't get to this before 2022-06-13 (in 10 days).
No worries, take your time. Thanks
Thank you for the review. I tried to address as many concerns as possible.
📌 Commit 1c2c236 has been approved by oli-obk
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request
[RFC 2011] Minimal initial implementation
Tracking issue: rust-lang#44838 Third step of rust-lang#96496
Implementation has ~290 LOC with the bare minimum to be in a functional state. Currently only searches for binary operations to mimic what assert_eq! and assert_ne! already do.
r? @oli-obk
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request
[RFC 2011] Minimal initial implementation
Tracking issue: rust-lang#44838 Third step of rust-lang#96496
Implementation has ~290 LOC with the bare minimum to be in a functional state. Currently only searches for binary operations to mimic what assert_eq! and assert_ne! already do.
r? @oli-obk
📌 Commit 605c64a has been approved by oli-obk
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
⌛ Testing commit 605c64a with merge 021f781df9f25e2a55fe359d1872a991e8b58b8a...
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
.......... (60/64)
.... (64/64)
/checkout/src/test/rustdoc-gui/toggle-docs.goml An exception occured: socket hang up
== STACKTRACE ==
Error
at innerRunTestCode (/node-v14.4.0-linux-x64/lib/node_modules/browser-ui-test/src/index.js:533:16)
at runMicrotasks (<anonymous>)
at processTicksAndRejections (internal/process/task_queues.js:97:5)
/checkout/src/test/rustdoc-gui/toggle-docs.goml An exception occured: socket hang up
WTF... Probably not related
yep it's spurious
@bors retry
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
This was referenced
Jun 15, 2022
Finished benchmarking commit (ca98305): comparison url.
Instruction count
- Primary benchmarks: no relevant changes found
- Secondary benchmarks: mixed results
| mean1 | max | count2 | |
|---|---|---|---|
| Regressions 😿 (primary) | N/A | N/A | 0 |
| Regressions 😿 (secondary) | 0.9% | 0.9% | 1 |
| Improvements 🎉 (primary) | N/A | N/A | 0 |
| Improvements 🎉 (secondary) | -0.3% | -0.3% | 1 |
| All 😿🎉 (primary) | N/A | N/A | 0 |
Max RSS (memory usage)
Results
- Primary benchmarks: mixed results
- Secondary benchmarks: mixed results
| mean1 | max | count2 | |
|---|---|---|---|
| Regressions 😿 (primary) | 0.8% | 0.9% | 2 |
| Regressions 😿 (secondary) | 2.2% | 3.1% | 4 |
| Improvements 🎉 (primary) | -5.2% | -5.2% | 1 |
| Improvements 🎉 (secondary) | -3.5% | -4.3% | 2 |
| All 😿🎉 (primary) | -1.2% | -5.2% | 3 |
Cycles
Results
- Primary benchmarks: 🎉 relevant improvement found
- Secondary benchmarks: no relevant changes found
| mean1 | max | count2 | |
|---|---|---|---|
| Regressions 😿 (primary) | N/A | N/A | 0 |
| Regressions 😿 (secondary) | N/A | N/A | 0 |
| Improvements 🎉 (primary) | -2.2% | -2.2% | 1 |
| Improvements 🎉 (secondary) | N/A | N/A | 0 |
| All 😿🎉 (primary) | -2.2% | -2.2% | 1 |
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.
@rustbot label: -perf-regression
Footnotes
bors added a commit to rust-lang-ci/rust that referenced this pull request
Checked the one regression locally with cachegrind, and it turns out it's actually an improvement, so that's just some perf noise
Labels
`#![feature(generic_assert)]`
This PR was explicitly merged by bors.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.