rustc_target: Add convenience functions for adding linker arguments by petrochenkov · Pull Request #98212 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation33 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
They ensure that lld and non-lld linker flavors get the same set of arguments.
The second commit also adds some tests checking for linker argument inconsistencies, and tweaks some arguments to fix those inconsistencies.
Relevant to the compiler team, which will review and decide on the PR/issue.
label
r? @estebank
(rust-highfive has picked a reviewer for you, use r? to override)
This comment was marked as resolved.
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me, cleaner and more efficient.
I left a couple questions, and apart from the pre-link args in wasm32-unknown-emscripten , r=me after rebase.
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
@bors r+ rollup=never
(so that it's easy to bisect in case we missed something)
📌 Commit f9e5d3b0327f8c71cbcb2634637b2bae0420595f has been approved by lqd
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
⌛ Testing commit f9e5d3b0327f8c71cbcb2634637b2bae0420595f with merge a0fc6e6516067988f123936386264e7a9b654e11...
This comment was marked as resolved.
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
GH network issues
@bors retry
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
This comment was marked as resolved.
📌 Commit ad2c36197a5c24e8398f097b1d9dcd19e27fe6a7 has been approved by lqd
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
This comment was marked as resolved.
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
📌 Commit 8a9bef063ddd4c0b68c94a7f489310433e35c9aa has been approved by lqd
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
This comment was marked as resolved.
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
They ensure that lld and non-lld linker flavors get the same set of arguments
📌 Commit 456f65e has been approved by lqd
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Finished benchmarking commit (221bdb6): comparison url.
Instruction count
This benchmark run did not return any relevant results for this metric.
Max RSS (memory usage)
Results
- Primary benchmarks: no relevant changes found
- Secondary benchmarks: 🎉 relevant improvements found
| mean1 | max | count2 | |
|---|---|---|---|
| Regressions 😿 (primary) | N/A | N/A | 0 |
| Regressions 😿 (secondary) | N/A | N/A | 0 |
| Improvements 🎉 (primary) | N/A | N/A | 0 |
| Improvements 🎉 (secondary) | -3.7% | -3.8% | 2 |
| All 😿🎉 (primary) | N/A | N/A | 0 |
Cycles
Results
- Primary benchmarks: 😿 relevant regression found
- Secondary benchmarks: 🎉 relevant improvements found
| mean1 | max | count2 | |
|---|---|---|---|
| Regressions 😿 (primary) | 8.0% | 8.0% | 1 |
| Regressions 😿 (secondary) | N/A | N/A | 0 |
| Improvements 🎉 (primary) | N/A | N/A | 0 |
| Improvements 🎉 (secondary) | -3.1% | -3.9% | 2 |
| All 😿🎉 (primary) | 8.0% | 8.0% | 1 |
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.
@rustbot label: -perf-regression
Footnotes
Labels
This PR was explicitly merged by bors.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.