Add new unstable API downcast to std::io::Error by NobodyXu · Pull Request #98387 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation23 Commits8 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
that accepts ErrorData<Box<Custom>>
Signed-off-by: Jiahao XU Jiahao_XU@outlook.com
that accepts ErrorData<Box<Custom>>
Signed-off-by: Jiahao XU Jiahao_XU@outlook.com
Signed-off-by: Jiahao XU Jiahao_XU@outlook.com
Signed-off-by: Jiahao XU Jiahao_XU@outlook.com
Relevant to the library team, which will review and decide on the PR/issue.
label
Hey! It looks like you've submitted a new PR for the library teams!
If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.
Examples of T-libs-api changes:
- Stabilizing library features
- Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
- Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
- Changing public documentation in ways that create new stability guarantees
- Changing observable runtime behavior of library APIs
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thomcc (or someone else) soon.
Please see the contribution instructions for more information.
Relevant to the library API team, which will review and decide on the PR/issue.
and removed T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay to me, in terms of the impl (but needs API sign off of course)
Signed-off-by: Jiahao XU Jiahao_XU@outlook.com
Emmm, the CI failed at downloading some tools using curl...
@joshtriplett I wrote most of the current io::Error implementation (and I think @yaahc is on vacation), so I'm probably fine as an impl reviewer for this (unless this is part of the new process for API review?).
This comment has been minimized.
@thomcc No problem; I just tend to bring error-related API review to @yaahc's attention.
@thomcc Pinging this PR as it has been stale for 17 days.
Reviewing now, thank you for the ping.
edit: left a comment on the ACP issue
Signed-off-by: Jiahao XU Jiahao_XU@outlook.com
Hey! It looks like you've submitted a new PR for the library teams!
If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.
Examples of T-libs-api changes:
- Stabilizing library features
- Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
- Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
- Changing public documentation in ways that create new stability guarantees
- Changing observable runtime behavior of library APIs
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should just need a tracking issue then it is good to go IMO. I have only one minor NIT comment that isn't a blocker.
Co-authored-by: Jane Losare-Lusby jlusby42@gmail.com
Add new unstable API Add new unstable API try_downcast_inner to std::io::Errordowncast to std::io::Error
Should just need a tracking issue then it is good to go IMO. I have only one minor NIT comment that isn't a blocker.
I've added the tracking issue in #99262
looks great, thank you again!
@bors r+
📌 Commit 8e8a3be has been approved by yaahc
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
JohnTitor added a commit to JohnTitor/rust that referenced this pull request
…owngrade_inner, r=yaahc
Add new unstable API downcast to std::io::Error
Signed-off-by: Jiahao XU Jiahao_XU@outlook.com
bors added a commit to rust-lang-ci/rust that referenced this pull request
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the library API team, which will review and decide on the PR/issue.