orphan check: rationalize our handling of constants by lcnr · Pull Request #99861 · rust-lang/rust (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

T: Trait, const VALUE: T isn't an issue, because T has to be forward declared, so if T is a local type, then the orphan check already succeeds the moment it sees T

for trait objects that's more difficult 😁 or well, it depends on whether we already have local values for const T: fn(). going to extend that comment.

feel like the value of allowing uncovered const params is still greater then allowing impls to be guarded by a local function pointer 😁 so this impl is still the right one imo