Add docs for building Fuchsia locally and in CI by tmandry · Pull Request #1989 · rust-lang/rustc-dev-guide (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments.

I'm not sure how widespread the "integration" nomenclature is, within the project, but it seems fine and people can nitpick the definition.

While I have you (I'm sure I asked this before, sorry), and related to the previous point, do you mind if we rename the job to something that contains the word "fuchsia"?

It wasn't clear to me whether integration also referred to your integration repo or to integration tests. (But I guess naming the jobs and builders is more of a t-infra decision)