feat(dist): add notes for stable
and beta
in components_missing_msg()
by rami3l · Pull Request #3920 · rust-lang/rustup (original) (raw)
Prepares for rls
' removal in the release channel.
Continuation of #3453, as requested by @onur-ozkan in rust-lang/rust#126856 (comment).
The best thing we could do is to add a note saying some components may no longer be available (this note currently doesn't apply for stables), but:
- We'll have to wait for v1.28 to ship it, and we're currently in the middle of the release cycle (we have limited bandwidth so we decided not to do backports), and
- We should not hardcode the list of removed components in Rustup
The error message is not final, since I'd still like to add a link that provides more info about removed components (which is The message now includes a link to https://rust-lang.github.io/rustup/devel/concepts/components.html#previous-components.rls
this time):
... and for this I suggest adding a section in the Rust docs somewhere, and our notes should advise the user to check out the section above to see whether the component in question is missing as intended from what date (and if that is the case, they can choose to unblock the update with a clear consent by removing the component).
But in any way we cannot simply skip RLS in an update if it's previously installed, since that would be a real backwards compatibility problem.
https://rust-lang.zulipchat.com/#narrow/stream/241545-t-release/topic/excluding.20rls.20from.20the.20release/near/447968780
Concerns
To which document should we add the list of removed components?To the Rustup User Guide, see above for details.Should the note be applied toNo, as feat(html): add a link to removed components rustup-components-history#54 will add a link to https://rust-lang.github.io/rustup/devel/concepts/components.html#previous-components on the components history page.nightly
as well?