Set line-comments by default like sass-rails by edward · Pull Request #24 · sass/sassc-rails (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation9 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Sets line_comments by default like sass-rails
Note that this depends on a patch version bump in sassc-ruby
Set line-comments by default like Set line-comments by default like sass-railssass-rails
@edward looks fine, but there's a test to fix up
@bolandrm it's failing because sassc-ruby needs an update. Should run green after my PR over there is merged and the test here re-run.
@edward sorry, i didn't quite understand what you meant initially. I bumped the sassc-ruby version, we good to merge this now?
@bolandrm heyo – let me rebase onto master and I’ll get the PR ready to merge.
@edward since i've added source maps, should we ensure that line comments get turned off when source maps get turned on? (I can do that, just asking)
@bolandrm Good question. I feel like libsass is usually smart enough to know which options to disable, e.g. if you turn on line comments but have a compressed style of output, it’ll ignore the line comments option.
Do you have time to write a test to see what the output looks like with both line comments and source maps?
@bolandrm It looks like we get output that looks like this:
"/* line 3, /home/vagrant/src/sassc-rails/test/dummy/app/assets/stylesheets/application.scss /\n.hello {\n color: #FFF;\n}\n\n/# sourceMappingURL=data:application/json;base64,ewoJInZlcnNpb24iOiAzLAoJImZpbGUiOiAic2Fzc2MtcmFpbHMvdGVzdC9kdW1teS9hcHAvYXNzZXRzL3N0eWxlc2hlZXRzL2FwcGxpY2F0aW9uLmNzcyIsCgkic291cmNlcyI6IFsKCQkic2Fzc2MtcmFpbHMvdGVzdC9kdW1teS9hcHAvYXNzZXRzL3N0eWxlc2hlZXRzL2FwcGxpY2F0aW9uLnNjc3MiCgldLAoJInNvdXJjZXNDb250ZW50IjogWwoJCSIkYi1jb2xvcjogI0ZGRjtcblxuLmhlbGxvIHtcbiAgY29sb3I6ICRiLWNvbG9yO1xufVxuIgoJXSwKCSJtYXBwaW5ncyI6ICI7QUFFQSxNQUFNLENBQUM7RUFDTCxLQUFLLEVBSEcsSUFBSTtDQUVOIiwKCSJuYW1lcyI6IFtdCn0= */"
I’ve confirmed that at least Chrome 43.0.2357.132 is happy with this and is able to pick out the inlined sourcemap since those lines go at the end of imported file statements, and not on the same lines as the comments.
Seems like we’re good here?
bolandrm added a commit that referenced this pull request
Set line-comments by default like sass-rails
2 participants
