Update from upstream and add support for running tests against docker redis instances by ejsmith · Pull Request #3 · shadim/StackExchange.Redis (original) (raw)

@mgravell @ejsmith

@mgravell @ejsmith

…the feature-flag

@gkorland @ejsmith

I checked the RediSearch source and found that it's been "Unsupported language" since at least August 28, 2018.

Index optimizations are now handled by the internal garbage collector in the background.

https://oss.redislabs.com/redisearch/Commands.html#ftoptimize

Made the private args member naming more consistent the rest of the project by prefixing with an underscore.

Kept everything as close to the original as possible.

Marked the obsolete unit test as obsolete.

Fixed some assertions...

Fixed some silly bugs...

Removed NOSCOREIDX as that has been deprecated.

Marked AggregationBuilder as sealed because (at least initially) we don't expect any inheritance here.

Dropped the call to ToString when appending the value for "MAX" to a SortBy clause because it isn't needed.

Changed ArgsString to a method to indicate that we're not simply exposing internal state. Made the method internal as it's present for test purposes.

Removed the Args property because it's not clear that we need it. It was ported from JRediSearch because it was there.

Cleaned up how we're ensuring that an object to compare is not null and is of an appropriate type.

Fixed equality check so that it doesn't blow up on null values (payload specifically).

Added in SetNoStopwords method to match the JRediSearch api as well as provide a conveinient means for keeping the default index options AND specifying that no stopwords be considered.

Fixed TestStopwords unit test by specifying STOPWORDS 0 by calling SetNoStopwords which adds the DisableStopWords option to the configured index options.

Added a small covering test.

Co-authored-by: Nick Craver nrcraver@gmail.com Co-authored-by: Marc Gravell marc.gravell@gmail.com

@mgravell @ejsmith

@naile @ejsmith

@ejsmith

@ejsmith

@ejsmith