Fix for Windows: do not run binaries from CWD by sharkdp · Pull Request #1724 · sharkdp/bat (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits2 Checks0 Files changed

Conversation

This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

sharkdp

This fixes a bug on Windows where Command::new would also run
executables from the current working directory, possibly resulting in
accidental runs of programs called less.

closes #1472

@sharkdp

This fixes a bug on Windows where Command::new would also run executables from the current working directory, possibly resulting in accidental runs of programs called less.

@sharkdp

@sharkdp sharkdp deleted the fix-relative-path-execution branch

July 12, 2021 21:17

@sharkdp

rhysd added a commit to rhysd/actionlint that referenced this pull request

Jul 14, 2021

@rhysd

@Enselic

@ChrisDenton

I would however note that the std has to be cautious about (potentially) breaking compatibility with prior versions of Rust. This means that even if that PR gets merged, it will still do more than just search PATH. I would love to further simplify it in the future but in the meantime it may still be worth it for applications to use a third party resolver (such as grep_cli).