Changeling and Traitor Gamerule fixes by Conflee · Pull Request #1244 · ss14Starlight/space-station-14 (original) (raw)

Short description

Adds a new gamerule, SubGamemodesRuleNoChangelings, and replaces the SubGamemodesRule in the Traitor and Traitorlings Gamemode with it. Adds Traitorlings to the vote pool as well.

Why we need to add this

There is already a Gamemode for Traitors + Changelings, called Traitorling. Leaving Lings in with normal Traitor rounds, in my opinion, was unintentional given the fact that it also had its own gamemode specifically for that, so I fixed it.

Changelings also spawn in large groups, which eat up all the Antag slots. Number of max antags is determined by player count. Changelings would use 6-8 of those slots, making it so only 2 Traitors could spawn in the Traitors gamemode.

The SubGamemodesRule in Traitorlings rolled on top of the already added Changeling gamerule, which was likely the cause of the double-Changelings issue we've had for months where Lings spawn 2 groups to end up with 6-8 Lings in a round.

Media (Video/Screenshots)

N/A

Checks

• I do not require assistance to complete the PR.
• Before posting/requesting review of a PR, I have verified that the changes work.
• I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
• I affirm that my changes are licensed under the Starlight Fork License and grant permission for use in this repository under its conditions.

Changelog

🆑 Conflee

• tweak: Changed how the Traitor Gamemode rolls antags to exclude Changelings, since there is already a Traitorling Gamemode that can roll, it seems unintended. Changelings stole all antag slots, making it so the game only spawned 2 Traitors on average.
• fix: Fixed (maybe) the game sometimes spawning two groups of Changelings at once. The old Traitorling Gamemode called SubGamemodesRule which could roll a second set of Lings.
• add: Added Traitorling to the Vote Pool as an option, as a medium-chaos option.
• add: Added EventLight gamemode, does not roll naturally or appear in votes. It's like Greenshift but less boring! Rolls Shuttle Events and Thieves.