Add an example of stdgpu::unordered_map by ykkawana · Pull Request #13 · stotko/stdgpu (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation2 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

It took me a bit while to grab how to use unordered_map, so I made this simple example code.

Thank you. I have a few remarks:

• container_kernel.cu contains a similar example on how to use the stdgpu::unordered_set within a kernel.
• There is also a similar code snippet in the examples section of the README.
• In your example, there are many calls to cudaMalloc, cudaFree and cudaMemcpy. I would prefer stdgpu's function, i.e. createDeviceArray etc.

Therefore, I think it is a good idea to add an explicit example for stdgpu::unordered_map. Please adapt it to match the other examples and the general coding style of the library.

More examples have been added by #173. In addition, much effort has been much put into improving the documentation, so I think it should be easier now for users to get an idea of the library.

If you still have suggestions on how to improve certain aspects of the library, please open an issue. Thanks again for your contribution. Closing.

Labels

2 participants