platform: Move STDGPU_HAS_CXX_17 to compiler by stotko · Pull Request #146 · stotko/stdgpu (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation1 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

@stotko

In #119, automatic dispatching support has been added to the platform module. However, this caused a regression in attribute where STDGPU_HAS_CXX_17 becomes undefined due to include changes. Since the latter is closer related to compiler rather than platform, move it to that place. Furthermore, extend the set of warnings to avoid such regressions in the future.

@stotko

@codecov

@stotko stotko deleted the compiler_undef_fix branch

May 1, 2020 12:33

Labels

2 participants

@stotko