compiler: Fix NVCC detection by stotko · Pull Request #155 · stotko/stdgpu (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation1 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

@stotko

The compiler module uses the __CUDA_ARCH__ define to detect NVCC. Since it is the only supported device compiler providing this define at the moment, the detection apparently seems to work. However, other compilers that also provide this define, e.g. Clang, may be added in the future which results in violating the current assumption. Use __NVCC__ instead of __CUDA_ARCH__ to fix this bug.

@stotko

@codecov

@stotko stotko deleted the compiler_nvcc_fix branch

May 8, 2020 10:22

Labels

2 participants

@stotko