cmake: Fix inconsistent thrust detection across the backends by stotko · Pull Request #92 · stotko/stdgpu (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation1 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

@stotko

CUDA ships the thrust library by default. Since it lives in the same include directory as the CUDA headers, the detection for the CUDA backend implicitly works. However, this prevents pointing to another (e.g. more recent) version of thrust. Furthermore, no version check is performed to ensure that the requirements are fulfilled. Change that to find thrust for all backends consistently. In addition, explicitly set the device backend for thrust when using CUDA to make this consistent to the OpenMP backend and become independent of thrust's default backend choice.

@stotko

@codecov

@stotko stotko deleted the cmake_thrust_cuda branch

February 7, 2020 12:26

This was referenced

Feb 8, 2020

Labels

2 participants

@stotko