cmake: Fix selection of header files for installation by stotko · Pull Request #93 · stotko/stdgpu (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation1 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

@stotko

To install header files, a blacklist approach is currently employed. However, as the internal structure of the project evolved over time, this list should have been updated as well but actually was not. Therefore, some auxiliary and source files will be accidentally installed. Use a whitelist approach which is easier to maintain, especially once #38 has been addressed.

@stotko

@codecov

@stotko stotko deleted the cmake_install_header_fix branch

February 7, 2020 13:40

Labels

2 participants

@stotko