Dark Mode support (original) (raw)

Prerequisites

• I verified that this is not a filter issue
  • Filter issues MUST be reported at filter issue tracker
• This is not a support issue or a question
  • Support issues and questions are handled at /r/uBlockOrigin
• I performed a cursory search of the issue tracker to avoid opening a duplicate issue
  • Your issue may already be reported.
• I tried to reproduce the issue when...
  • uBlock Origin is the only extension
  • uBlock Origin with default lists/settings
  • using a new, unmodified browser profile
• I am running the latest version of uBlock Origin
• I checked the documentation to understand that the issue I report is not a normal behavior

Description

macOS 10.14 introduced "dark mode", which swaps the system color palette to a dark scheme. Chrome just added support for this in Google Chrome Canary. uBlock Origin doesn't currently support this. I realize this is Canary, however Dark Mode will be added to a future version of Google Chrome. It is presently on track to be in m73 (March 12, 2019) or m74 (April 23, 2019). NOTE: This is not a Canary "Bug" it is a new feature that will be added to chrome.

A specific URL where the issue occurs

Chromium Issue Tracker showing "Dark Mode" is now enabled by default in Chromium. As Google Chrome Canary is built off master nightly, this is present there. https://bugs.chromium.org/p/chromium/issues/detail?id=850098#c58
Release Schedule for Chromium/Chrome: https://www.chromium.org/developers/calendar

Steps to Reproduce

1. Open Google Chrome Canary (must be updated past Thursday, January 24, 2019's nightly build.
2. Open any of uBlock Origin's menus (i.e. click icon in menu bar, go to extension settings, etc.)

Expected behavior:

uBlock Origin's Menu pages are bright white with black text. They should (in theory) follow Google Chrome Canary's default color scheme, which has now been expanded.

Actual behavior:

Google Chrome Canary appears in dark mode, however uBlock Origin menus are all bright white with black text (same as normal mode)

Your environment

• uBlock Origin version: 1.18.1rc0
• Browser Name and version: Google Chrome Canary (Version 73.0.3683.3 (Official Build) canary (64-bit))
• Operating System and version: macOS Mojave (Version 10.14.3)