Cosmetic filtering issue with Shadow DOM/tree/root · Issue #803 · uBlockOrigin/uBlock-issues (original) (raw)

Details

Prerequisites

Description

  1. Generic cosmetic filters don't hide nodes in Shadow DOM. Probably not injected to the page because nodes "in shadow" are not detected.
  2. Specific filters works, but are not logged.
    • This does not work in ABP/AdBlock.

A specific URL where the issue occurs

https://www.virustotal.com/gui/home/upload

Steps to Reproduce

"Generic" case:

  1. Add ###euConsent to My filters
  2. Open linked VirusTotal page

"Specific" case:

  1. Add virustotal.com###euConsent to My filters
  2. Open linked VirusTotal page

Expected behavior:

Cookie notice on the bottom should be hidden with generic filter. Filter should be logged.

Actual behavior:

Notice is hidden only by specific filter. No DOM filters are logged.

Your environment


@krystian3w, it's side effect of uBO performance/memory optimizations. ABP injects all cosmetic filters unconditionally (AFAIK). uBO injects only specific filters. For generic filters, DOM is scanned and only matching ones are injected. Here Shadow DOM is interfering.