Comparing v57...v58 · ubuntu/gnome-shell-extension-appindicator (original) (raw)

Commits on Apr 18, 2024

1. Configuration menu
   Browse the repository at this point in the history
2. Configuration menu
   Browse the repository at this point in the history
3. Configuration menu
   Browse the repository at this point in the history
4. Fix first click being treated as both a single and double click by de…
   …leting vfunc_button_release_event
   Fixes #516
   The problem is that both vfunc_button_press_event and vfunc_button_release_event call _maybeHandleDoubleClick the first time around, so a press+release becomes a double click. But the second time, this._indicator.supportsActivation has been set to true instead of undefined, so vfunc_button_release_event doesn't trigger the double click.
   The deleted code cannot be useful because...

• if supportsActivation is false, _maybeHandleDoubleClick immediately returns EVENT_PROPAGATE
• if supportsActivation is true, vfunc_button_release_event skips _maybeHandleDoubleClick and returns EVENT_PROPAGATE
• if it's undefined and changes value, we get the aforementioned bug.
  
  Jing Wang authored and3v1n0 committed
  Apr 18, 2024
  Configuration menu
  Browse the repository at this point in the history

1. appIndicator: Try to introspect the application for Activate method s…
   …upport
   Since its presence may lead to a delay to handle the double click, let's
   try to check early if the application supports it or not.
   Sadly the protocol does not explicitly state if this is supported, and
   while it's normally true just for kde appindicators and not for the
   ubuntu ones it's better to be generic
   
   3v1n0 committed
   Apr 18, 2024
   Configuration menu
   Browse the repository at this point in the history
2. Configuration menu
   Browse the repository at this point in the history
3. Configuration menu
   Browse the repository at this point in the history
4. Configuration menu
   Browse the repository at this point in the history
5. Configuration menu
   Browse the repository at this point in the history
6. Configuration menu
   Browse the repository at this point in the history
7. Configuration menu
   Browse the repository at this point in the history
8. Configuration menu
   Browse the repository at this point in the history
9. Configuration menu
   Browse the repository at this point in the history
10. Configuration menu
    Browse the repository at this point in the history
11. Configuration menu
    Browse the repository at this point in the history