[V2] Color degredations (original) (raw)

I am on the latest Hyper.app version
I have searched the issues of this repo and believe that this is not a duplicate
OS version and name: macOS 10.13.0
Hyper.app version: 2.0.4 & 1.4.8
Link of a Gist with the contents of your .hyper.js: https://gist.github.com/mike-engel/0fcc34f787fa7875e91faf36ea19d67a
Relevant information from devtools: N/A
The issue is reproducible in vanilla Hyper.app: Yep. Moving my hyper.js config to another location and restarting also has bad color representations.

Issue

While moving to 2.0, I've noticed that colors are not behaving properly anymore. In programs like Vim the colors between 2.x and 1.x are vastly different. While debugging, I also noticed that the color representations between the two versions seem to be much different.

Referring to this gist and this script, you can see from my screenshots that there are some differences.

This may be an issue with xterm.js, so if it is, let me know and I'll move over there. Here's my vim config as well. It's important to note that that exact vim config looks ok on 1.x, but not ok on 2.x.

Please let me know if there's any info you need. If you have some general ideas on where to start, I can work on a PR. Thanks!

EDIT: It seems like xterm.js doesn't support truecolor, which may be part of the problem with the color script, but doesn't explain the vim differences.

[V2] Color degredations (original) (raw)

Issue

Screenshots

Vim

Color script

2.x

1.x