fix(browser): fix stale source map on watch mode by hi-ogawa · Pull Request #10389 · vitest-dev/vitest (original) (raw)
Description
- Closes Browser mode stack trace is off after file change on watch mode #10388
- Related refactor(utils): move extractSourcemapFromFile to utils #9721
Apparently #9721 introduced a bug. It added the cache for the case that wasn't cached before and that contradicts with the comment at the sourceMapCache:
| // cache for non-vite source maps |
|---|
| private sourceMapCache = new Map<string, any>() |
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
- It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
- Ideally, include a test that fails without this PR but passes with it.
- Please, don't make changes to
pnpm-lock.yamlunless you introduce a new test example. - Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.
Tests
- Run the tests with
pnpm test:ci.
Documentation
- If you introduce new functionality, document it. You can run documentation with
pnpm run docscommand.
Changesets
- Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with
feat:,fix:,perf:,docs:, orchore:.