[Quantization] Bump compressed-tensors version; update NVFP4A16 test model by dsikka · Pull Request #19224 · vllm-project/vllm (original) (raw)
Hello @dsikka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
Hello team, Gemini here, providing a summary of this pull request to help everyone quickly understand the changes. This PR primarily focuses on updating the compressed-tensors dependency to version 0.10.0. Along with this dependency update, the PR adjusts the test suite for NVFP4A16 quantization to align with a new strategy introduced in the updated library, specifically changing the validation logic to check for the TENSOR_GROUP strategy instead of the older GROUP strategy.
Highlights
- Dependency Update: The
compressed-tensorslibrary dependency has been updated from version0.9.4to0.10.0inrequirements/common.txt. - Test Model Update: The test model used for the
test_compressed_tensors_nvfp4a16test has been updated fromnm-testing/TinyLlama-1.1B-Chat-v1.0-FP4tonm-testing/TinyLlama-1.1B-Chat-v1.0-NVFP4A16. - Quantization Strategy Validation: The internal logic within
vllm/model_executor/layers/quantization/compressed_tensors/compressed_tensors.pyfor identifying NVFP4A16 quantization has been updated to check for theTENSOR_GROUPstrategy, reflecting changes in the newcompressed-tensorsversion.
Changelog
- requirements/common.txt
- Updated the
compressed-tensorsdependency version from 0.9.4 to 0.10.0.
- Updated the
- tests/quantization/test_compressed_tensors.py
- Changed the test model name string used in
test_compressed_tensors_nvfp4a16to reference the updated NVFP4A16 model.
- Changed the test model name string used in
- vllm/model_executor/layers/quantization/compressed_tensors/compressed_tensors.py
- Modified the
_is_fp4a16_nvfp4method to check for theTENSOR_GROUPquantization strategy instead of theGROUPstrategy. Using Gemini Code Assist
- Modified the
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review | Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary | Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help | Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A dependency bumps,
Tests need new jumps.
From GROUP to TENSOR,
A change for the sensor,
No more old humps.
- Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩