[cssom][css-conditional][css-images] Switch CSS to use IDL namespace by zcorpan · Pull Request #437 · w3c/csswg-drafts (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation13 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
The change seems fine. The question is which browsers are willing to try it to see whether it's web-compatible and whether we actually want to change the spec before such trials happen.....
If Web-compat seems likely, then we should change the spec, and put a note that it may be reverted if Web-compat problems are found. If Web-compat seems unlikely, then maybe just put a note that we're in the process of trying this out and the spec may be updated if it ends up working.
Or maybe we can just wait with merging this until someone has tried to ship.
Seems like an obscure approach, is the problem. This way it's documented where the feature itself is documented.
I'm happy to merge this now with a note in CSSOM next to the definition that it's contingent on web-compat. Do you want me to just add that in and merge it, @zcorpan?
Should add support for namespaces in web-platform-tests's idlharness.js and add an interfaces.html test for cssom (and cssom-view).
That ended up with the wrong pull request number in the commit message... ah, well.
@tabatkins Are there existing bugs reported against browsers for this?
That looks like the bug on supporting namespace at all, not for "CSS should be a namespace".
I guess the question is who is responsible for making sure that UAs actually investigate whether this is shippable.
The second comment on that bug is about the CSS namespace specifically.
Yes, it's about the fact that the functionality is needed for that. I'll be pretty surprised if this change gets made in that bug.
Anyway, I landed this in Gecko in https://bugzilla.mozilla.org/show_bug.cgi?id=1455805 but in general the CSSWG really should start filing bugs when spec changes happen....
fergald pushed a commit to fergald/csswg-drafts that referenced this pull request
foolip added a commit to foolip/css-houdini-drafts that referenced this pull request
tabatkins pushed a commit to w3c/css-houdini-drafts that referenced this pull request
Reviewers
