[css-images-3] remove && from syntax by 12Me21 · Pull Request #8021 · w3c/csswg-drafts (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation4 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
c03b2ea changed <color-stop> = <color> <length-percentage>? to <linear-color-stop> = <color> && <length-percentage>?
I believe the && was a mistake, since <length-percentage> <color> doesn't seem to be valid?
Note: This also affects [css-images-4], which uses the same definition.
I assume this was a typo?
@tabatkins could you review, and confirm && was a mistake?
Also for what it is worth, Chrome and FF do not parse position(s) before the color as valid, and if it should be allowed, it may be odd to be able to specify both positions before or after the color, but not a color between them.
Yeah, reviewing the diff I'm almost certain it was just a mistake while writing it - it looked reasonable to use an && in the grammar while I was rewriting. I still think it's probably reasonable to do so, but nobody's followed that in forever and it's not very important, so reverting to the old spec text which matches impls makes sense.
cdoublev added a commit to cdoublev/csswg-drafts that referenced this pull request
tabatkins pushed a commit that referenced this pull request