Reference tests for display:contents · Pull Request #1129 · w3c/csswg-test (original) (raw)

ghost

It was not clear to me from the spec what the expected result of applying display:contents to replaced elements is. The added test for replace contents matches what Gecko implemented.


This change is Reviewable

Rune Lillesveen added 2 commits

September 19, 2016 13:19

@syncbot

@syncbot

Automatic validation checks of commit b901323 passed.

zcorpan

You should see the word PASS without extra spacing below.

PASS

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add <tr>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

You should see the word PASS without extra spacing below.

PASS

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add <tr>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

You should see the word PASS below.

PASS

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add <tr>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

CSS Reftest Reference

You should see the word PASS below.

PASS

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you share reference file more? The first-line and first-letter ones are identical, at least, and most of the others that say "PASS" could be adjusted to be identical and share ref I think.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've re-organized a bit to do this. I split the margin-collapsing through display:contents into a separate test (block-002)

@@ -0,0 +1,16 @@
CSS Display: display:contents and ::first-line

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack