Addition: support geolocation emulation by sadym-chromium · Pull Request #183 · w3c/geolocation (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation34 Commits18 Checks3 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This was referenced
Mar 17, 2025
At a high level this looks right to me (i.e. I think it matches the WebDriver API in which you provide either a full set of overrides, or null).
As a general comment, please add the markup to indicate that these changes are "Candidate Additions". See the existing annotations in the spec for examples.
[WIP] feat: support geolocation emulation Addition: support geolocation emulation
As a general comment, please add the markup to indicate that these changes are "Candidate Additions". See the existing annotations in the spec for examples.
done
Converting for draft to wait for the webdriver-bidi specification and corresponding WPT tests are landed.
In the "implementation commitment" section above, shouldn't we still make sure that browsers are committed to implementing the new WebDriver BiDi commands?
Co-authored-by: Reilly Grant reillyeon@users.noreply.github.com
Co-authored-by: Reilly Grant reillyeon@users.noreply.github.com
Co-authored-by: Reilly Grant reillyeon@users.noreply.github.com
Co-authored-by: Reilly Grant reillyeon@users.noreply.github.com
Co-authored-by: Reilly Grant reillyeon@users.noreply.github.com
Co-authored-by: Reilly Grant reillyeon@users.noreply.github.com
Co-authored-by: Reilly Grant reillyeon@users.noreply.github.com
Co-authored-by: Reilly Grant reillyeon@users.noreply.github.com
This change looks good to me, however we still need to get implementation commitment signals from browser engines. Assuming no engine has already implemented the new WebDriver BiDi commands, please file issues for each engine and update the PR template with links to them.
Co-authored-by: Reilly Grant reillyeon@users.noreply.github.com
This change looks good to me, however we still need to get implementation commitment signals from browser engines. Assuming no engine has already implemented the new WebDriver BiDi commands, please file issues for each engine and update the PR template with links to them.
done
Why is WebKit marked "N/A"?
Why is WebKit marked "N/A"?
I'm not aware of WebKit's commitment of supporting geolocation emulation, so I marked it as N/A. I guess the proper way to signal it is just to unmark the checkbox, which I just did.
Please file an issue against WebKit so we can get signals directly from the team. Or maybe @marcoscaceres can comment here.
Please file an issue against WebKit so we can get signals directly from the team. Or maybe @marcoscaceres can comment here.
done
@reillyeon do you think we have any other blockers?
It looks like we have consensus from Blink and Gecko. @marcoscaceres, can you ask someone from WebKit to take a look? I'm comfortable merging this now as a candidate addition given current interest signals.
github-actions bot added a commit that referenced this pull request
SHA: 69cc724 Reason: push, by reillyeon
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>