Require sticky activation to perform vibrate by anssiko · Pull Request #30 · w3c/vibration (original) (raw)

anssiko

Also:

(Future work: refactor to use the fancier ref syntax.)

Fix #29


Preview | Diff

@anssiko

Also:

(Future work: refactor to use the fancier ref syntax.)

Fix #29

@anssiko

PTAL @johannhof

Also, PR Preview integration seems to have a bad day today (Internal Server Error), FYI @xfq

@xfq

Also, PR Preview integration seems to have a bad day today (Internal Server Error), FYI @xfq

It's tracked in tobie/pr-preview#124

alstjd4153

rakuco

@anssiko

Also use new method steps prose for vibrate()

@anssiko

@anssiko

rakuco

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for making the adjustments!

@anssiko

Re-requesting @rakuco in an attempt to unblock merge.

rakuco

@rakuco

It still says At least 1 approving review is required by reviewers with write access here.

@anssiko

@johannhof

PTAL @johannhof

Apologies, I keep being a bit late on your requests but it looks like @rakuco covered it well. No other comments from me :)

Thanks!

@xfq

@xfq

@anssiko

@anssiko anssiko deleted the sticky-activation branch

June 1, 2022 05:09