Fix MobileILStrip handling of unmanaged dlls by jkurdek · Pull Request #21098 · dotnet/macios (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation74 Commits7 Checks33 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This comment has been minimized.

@rolfbjarne it seems to me after inspection of binlogs that ILstrip was not run for any of the test. I can see the _RunAotCompiler property being false.

@rolfbjarne it seems to me after inspection of binlogs that ILstrip was not run for any of the test. I can see the _RunAotCompiler property being false.

The bots were probably all x64 bots.

I'll try locally and see what I get.

It seems the ResolveAssemblyReferences task just removes the reference to NativeLibrary.dll:

/Users/rolf/work/maccore/net9.0/xamarin-macios/builds/downloads/dotnet-sdk-9.0.100-rc.2.24420.1/sdk/9.0.100-rc.2.24420.1/Microsoft.Common.CurrentVersion.targets(2413,5): warning MSB3246: Resolved file has a bad image, no metadata, or is otherwise inaccessible. Invalid number of sections declared in PE header. Invalid number of sections declared in PE header. [/Users/rolf/work/maccore/net9.0/xamarin-macios/tests/xharness/bin/Debug/tmp-test-dir/monotouch-test1066/monotouch-test.csproj]

So it never reaches the ILStrip target.

Binlog:
build-iOS_Unified64-20240902_191140.binlog.zip

jkurdek marked this pull request as ready for review

September 3, 2024 21:07

Thanks @rolfbjarne, the dll was referenced incorrectly. I did verify locally that without changing the MobileILStrip task we get a failure, and that the proposed fix works.