Improve the header of pending comments in merge requests (#7905) · Issues · GitLab.org / GitLab · GitLab (original) (raw)

Skip to content

GitLab Next

• • Why GitLab
  • Pricing
  • Contact Sales
  • Explore
• Why GitLab
• Pricing
• Contact Sales
• Explore
• Sign in
• Get free trial

Improve the header of pending comments in merge requests

Summary

From https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/7376#note_106112838.

When we started using the implemented UI a bit more, it felt like it had too much empty space at the top, so @pedroms suggested an improvement that we'll tackle as follow-up:

• moving the “Pending” badge next to the user's name (I mean, you already know it's you who is commenting)
• and re-using the checkmark design to indicate if you the discussion stays/will be resolved/unresolved

Currently implemented	Proposal

This will also mitigate the lack of ability to edit a pending comment (in a discussion) and switch between resolving or not the discussion when published. We can toggle it directly in the header with this change. The tooltips should read accordingly: Discussion will be resolved., Discussion stays resolved., Discussion will be unresolved., or Discussion stays unresolved..

Being able to edit the resolvability of a comment will be tackled in https://gitlab.com/gitlab-org/gitlab-ee/issues/7920

🔍 Design specs with the most up-to-date solution and implementation notes

Edited Dec 08, 2020 by 🤖 GitLab Bot 🤖