gio/gsocketclient.c · main · GNOME / GLib · GitLab (original) (raw)

Skip to content

GitLab

• Explore

• Sign in

• glib

• gio

• gsocketclient.c

Blame Permalink

• 
  Nov 22, 2023
  234871f1
  gsocketclient: Fix a leak of the task data on an error path · 234871f1
  Philip Withnall authored Nov 22, 2023
  Once the task is completed (and g_task_return_*() has been called),
  the task is no longer needed. It would make more sense to unref it in
  complete_connection_with_error(), where g_task_return_*() is called,
  but that complicates other call sites significantly, so I didn’t do it.
  Signed-off-by: Philip Withnall <pwithnall@gnome.org>
  Fixes: #3184
  234871f1
  gsocketclient: Fix a leak of the task data on an error path
  Philip Withnall authored Nov 22, 2023
  Once the task is completed (and g_task_return_*() has been called),
  the task is no longer needed. It would make more sense to unref it in
  complete_connection_with_error(), where g_task_return_*() is called,
  but that complicates other call sites significantly, so I didn’t do it.
  Signed-off-by: Philip Withnall <pwithnall@gnome.org>
  Fixes: #3184

Loading